updated submit button logic for progress form #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skt17 is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
skt17
force-pushed
the
bugfix/Disabled-button-update-progress
branch
2 times, most recently
from
c6dd3e6
to
313be1a
Compare
Can you fill the description? |
shubhamsinghbundela
approved these changes
Oct 9, 2023
shubhamsinghbundela
suggested changes
Oct 9, 2023
skt17
force-pushed
the
bugfix/Disabled-button-update-progress
branch
from
313be1a
to
9d9973d
Compare
satyam73
requested changes
Oct 9, 2023
|
Hey @skt17, Instead of providing a ZIP file, can you share the proof video which can be viewed here in the description |
shubhamsinghbundela
approved these changes
Oct 10, 2023
shubhamsinghbundela
merged commit 110ddde
into
Real-Dev-Squad:develop
1 of 2 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Disabled button is getting clicked in update progress
Description:
When going to the update progress we get redirected to form to update our task progress. In initial state there's no data present in the from and the button is disabled in state(as it looks in UI). But when we try to click the button with empty form it gets clicked and the API is also being called which shouldn't happen. #916
Anything you would like to inform the reviewer about:
Dev Tested:
Images/video of the change:
demo.mp4
Follow-up Issues (if any)