Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UTC time format on idle page #933

Merged
merged 2 commits into from
Oct 13, 2023
Merged

add UTC time format on idle page #933

merged 2 commits into from
Oct 13, 2023

Conversation

anishpawaskar
Copy link
Contributor

@anishpawaskar anishpawaskar commented Oct 13, 2023 •
edited

Issue: #932

Description:

  • The idle page where we show idle users and their time/day for how long they have been idle. So to show time/day we are not using UTC time format.
  • So i have added UTC time format there.

Anthing you would like to inform the reviewer about:

  • Didn't write any test cause it is not require and test are already written for card component.

Dev Tested:

  • Yes

Image proof :-
Idle Users _ Status Real Dev Squad _ Status Real Dev Squad - Google Chrome 14-10-2023 02_50_09

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 10:35am

@anishpawaskar anishpawaskar changed the title add UTC time format add UTC time format on idle page Oct 13, 2023
Achintya-Chatterjee
Achintya-Chatterjee reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anishpawaskar add a working proof and also tests the stats

@iamitprakash iamitprakash merged commit 1a37917 into develop Oct 13, 2023
3 checks passed
@iamitprakash iamitprakash deleted the add-UTC-time-format branch October 13, 2023 23:13
@anishpawaskar anishpawaskar mentioned this pull request Oct 14, 2023
Merged
@ajoykumardas12 ajoykumardas12 mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamitprakash iamitprakash iamitprakash approved these changes

@j24m j24m j24m approved these changes

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anishpawaskar @iamitprakash @j24m @Achintya-Chatterjee