Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring css and html files #201

Merged
merged 6 commits into from
Dec 30, 2021
Merged

Refactoring css and html files #201

merged 6 commits into from
Dec 30, 2021

Conversation

rohan09-raj
Copy link
Contributor

@rohan09-raj rohan09-raj commented Dec 27, 2021 •
edited

Refactored and rewritten all the CSS for main page
Please check to deploy preview for the visual view.

@netlify
Copy link

netlify bot commented Dec 27, 2021 •
edited

✔️ Deploy Preview for staging-welcome-site ready!

🔨 Explore the source changes: 6990b26

🔍 Inspect the deploy log: https://app.netlify.com/sites/staging-welcome-site/deploys/61cd6a993b537f000797bb03

😎 Browse the preview: https://deploy-preview-201--staging-welcome-site.netlify.app

@netlify
Copy link

netlify bot commented Dec 27, 2021 •
edited

✔️ Deploy Preview for staging-welcome ready!

🔨 Explore the source changes: d1abe7f

🔍 Inspect the deploy log: https://app.netlify.com/sites/staging-welcome/deploys/61c956b667cd5900073ac33f

😎 Browse the preview: https://deploy-preview-201--staging-welcome.netlify.app

@netlify
Copy link

netlify bot commented Dec 27, 2021 •
edited

✔️ Deploy Preview for staging-welcome ready!

🔨 Explore the source changes: 6990b26

🔍 Inspect the deploy log: https://app.netlify.com/sites/staging-welcome/deploys/61cd6a99a359c00007e5bea2

😎 Browse the preview: https://deploy-preview-201--staging-welcome.netlify.app

This was referenced Dec 29, 2021
Closed
Closed
Rucha1499
Rucha1499 suggested changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@Rucha1499 Rucha1499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring the code and fixing the design! @rohan09-raj 💯

Just requesting some minor changes. Please have a look at them.

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
Ishikabaid
Ishikabaid suggested changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@Ishikabaid Ishikabaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot (6)
Can we move this colon with the above text? It's looking very weird here.

@rohan09-raj
Copy link
Contributor Author

rohan09-raj commented Dec 30, 2021 •
edited

@Ishikabaid Can you please mention the dimensions ?? Because in my local at all the breakpoints it is fine.

@Ishikabaid
Copy link
Contributor

@Ishikabaid Can you please mention the dimensions ?? Because in my local at all the breakpoints it is fine.

I checked it for Moto G4

@rohan09-raj
Copy link
Contributor Author

@Ishikabaid Can you please mention the dimensions ?? Because in my local at all the breakpoints it is fine.

I checked it for Moto G4

Resolved. Please check now

@Ishikabaid
Copy link
Contributor

@Ishikabaid Can you please mention the dimensions ?? Because in my local at all the breakpoints it is fine.

I checked it for Moto G4

Resolved. Please check now

Thanks for the changes @rohan09-raj . Looks good to me🎉

Rucha1499
Rucha1499 approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@Rucha1499 Rucha1499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! @rohan09-raj 🎉

@Rucha1499 Rucha1499 merged commit 90c6873 into develop Dec 30, 2021
@rohan09-raj
Copy link
Contributor Author

Thank you for fixing this! @rohan09-raj 🎉

You're welcome 😃

@rohan09-raj rohan09-raj deleted the fix/css-section-one branch December 30, 2021 16:34
This was referenced Jan 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishikabaid Ishikabaid Ishikabaid approved these changes

@Rucha1499 Rucha1499 Rucha1499 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohan09-raj @Ishikabaid @Rucha1499