Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] PvP Rankings #37

Closed
whitewillem opened this issue Feb 9, 2020 · 3 comments · Fixed by #120
Closed

[Feature Request] PvP Rankings #37

whitewillem opened this issue Feb 9, 2020 · 3 comments · Fixed by #120
Labels
enhancement New feature or request

Comments

@whitewillem
Copy link
Contributor

Is your feature request related to a problem? Please describe.
More and more users are looking for PvP mons. But we dont have any way to show how good mons are or easy filter on them.

Describe the solution you'd like
Invent a ranking system based on IV stats for each league and store it in pokemon table / send it in webhook.

Describe alternatives you've considered
Implementation in PMSF. But i dont think thats the proper way to do it.

@whitewillem whitewillem added the enhancement New feature or request label Feb 9, 2020
@123FLO321
Copy link
Collaborator

How would that be calculated? @whitewillem

@whitewillem
Copy link
Contributor Author

this is a pretty clean example of how it could be calculated: https://github.com/PartTimeJS/WDR/blob/master/static/PvPRank.js.script

@jorgitoh
Copy link

jorgitoh commented Mar 12, 2020

I did something similar a little over a year ago. In the first version used calculations but even having very few phones, pokemon and a good memcache the operation was somewhat expensive.

The solution I found, even without being the best, was to set up an auxiliary table only for the great league. This table what I was doing was acting alongside the insert / update of a pokemon taking the corresponding ranking and putting it in a new column automatically. Each pokemon knew where to look for its ranking, that is, if a bulbasaur came out, the corresponding ranking to look for was venusaur, as long as the CP or level is not exceeded.

The auxiliary table was huge. I'm talking 4096 records for every Pokemon x 2 if you want to span Great + Ultra

@123FLO321 123FLO321 linked a pull request May 24, 2020 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants