PVP Stats

[123FLO321]

Description

• adds pvp stats for great and ultra league
• added pvp_rankings_great_league and pvp_rankings_ultra_league columns to pokemon table
• added pvp_rankings_great_league and pvp_rankings_ultra_league to pokemon webhook
• added pvp ranking info to pokemon marker popup
• added image generator for Italian Language Support #1, Should be Meteor Mash #2 and Should be Muddy Water #3 pvp pokemon (add the icons bellow to the misc folder

Icons

• first.png:
  
• second.png:
  
• third.png
  

Format

{
    "pvp_rankings_ultra_league": [
        {
            "rank": 2007,
            "percentage": 0.7161216527817746,
            "pokemon": 410,
            "form": 0,
            "level": 40.0,
            "cp": 69
        },
        {
            "percentage": 0.7999241285739804,
            "pokemon": 411,
            "form": 0,
            "rank": 3007,
            "level": 25.5,
            "cp": 420
        }
    ],
    "pvp_rankings_great_league": [
        {
            "form": 0,
            "pokemon": 410,
            "rank": 2007,
            "percentage": 0.7161216527817746,
            "level": 40,
            "cp": 69
        },
        {
            "rank": 3007,
            "form": 0,
            "pokemon": 411,
            "percentage": 0.7999241285739804,            
            "level": 25.5,
            "cp": 420
        }
    ],
   ...
}

Motivation and Context

includes #119

How Has This Been Tested?

Tested locally. Needs more testing

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[LordJavi]

Has been running 24h without issues

[LordJavi]

I think Galarian form doesn't evolves

[123FLO321]

@LordJavi Stunfisk doesn‘t have an evo in general right?

[unseenmagik]

Suffering huge CPU issues with the PR.

[LordJavi]

oh, you're right

In this case, rank is wrong.

15/15/15 -> 2162CP rank1 for UL

[DavisPoGo]

I've been running this for the past couple days. The pvp aspect of this works well. The CPU consumption needs to be looked at. When I first ran this, I did not add the new icons and the increase to CPU was noticeable but pretty minor. Then, I added the icons and restarted. The CPU was >90% during icon creation. I expected the load to be reduced after all the icons were generated but this was not the case. Even after icons were generated and I restarted RDM, CPU load was >90%. So, I removed all the new icons and restarted. CPU load dropped back to normal.

[LordJavi]

Some problems with Oddish (evolve to Bellossom)

Bellossom is rank2 and RDM says rank1

Probably it happens with more pokémon

[123FLO321]

Thats just a rounding problem. Notice how they are extremely close in ranking points.
Also in the first picture both have the same pointe (making the both nr1).
RDM doesn‘t round the result while other sources might. If you someone can tell me what correct implementation is I‘ll fix it but every pokemon pvp rankings list rounds differently.

[LordJavi]

Thats just a rounding problem. Notice how they are extremely close in ranking points.
Also in the first picture both have the same pointe (making the both nr1).
RDM doesn‘t round the result while other sources might. If you someone can tell me what correct implementation is I‘ll fix it but every pokemon pvp rankings list rounds differently.

Not really, but if CP is calculated can't be compared? rank 1 always have best CP, isn't?

[123FLO321]

That shouldn't matter.
Both have the same PVP rating and therefore a both number 1

[123FLO321]

Does the performance problem still exist?

[DavisPoGo]

With the latest commits, the CPU usage is not significantly higher than rdm without this pr. During image generation, CPU usage spikes but once that is complete, CPU drops to normal. PVP calculations look good as well. Ready to merge in my opinion,

[kbtbc]

That shouldn't matter.
Both have the same PVP rating and therefore a both number 1

Given identical PVP ratings, why wouldn't CP then be the deciding factor? It could matter depending on the match-ups if a 2281 CP vs a 2275 CP allows the Pokemon to absorb one more hit, thus making it "better". It seems like it should matter.

[123FLO321]

@kbtbc i believe thats already taken into account when calculating the pvp value

[123FLO321]

Their attack defense and stamina values (not IV but calculated values) are identical just happens to not be identical CP because of how pogo calculates cp

[kbtbc]

Ok, cool. I'm pulling now to test.

When you merge, please add a 'if exists drop' for the db migration ;-)

[kbtbc]

I have deployed the latest version of this, and it seems to be running fine last 30min. No noticable cpu spike. I am not running the front-end, so no image-generation was done in my test.

I do see the new values updated in the new pvp fields in my db. Everything seems to be functioning fine.

...Will there also be an update to the Poracle PR?
see: KartulUdus/PoracleJS#151 (comment)