Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Updating master to support react > 16 + native > 0.52 #158

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gabrielrotbart
Copy link

@gabrielrotbart gabrielrotbart commented Feb 20, 2018

Went through and fixed all the deprecated API's.

  • PropTypes imported from 'prop-types'
  • createClass to createReactClass
  • Updated dependencies

Fixes #139

It's probably not the cleanest update and I didn't add any tests but they all pass.

Enzyme works with react-native >= 0.52 which is what I needed.

Let me know if there are any issues I'm missing.

@gabrielrotbart
Copy link
Author

Using react-addons-perf latest version but its not compatible with React 16. Not sure how to fix this or why it's working fine for me. Will need to find time to dig into it further

@RealOrangeOne
Copy link
Owner

I believe most of these changes are fixed in #120 ?

@gabrielrotbart
Copy link
Author

I saw a mention of the re-write in one of the issues. The changes I pushed got my test suite running again with React > 16 so was just trying to help folks that are stuck until the re-write lands.

@saraht129
Copy link

any chance we can get this merged?

@pumano
Copy link

pumano commented Mar 12, 2018

I also waiting for this patch. React 16.2 + latest RN not working with react-native-mock

@heysailor
Copy link

@just4fun
Copy link

Still waiting for this patch.

Copy link

@hamoudaarfaoui hamoudaarfaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'number' of undefined
7 participants