Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to show QuickFolders tabs below main toolbar #20

Closed
RealRaven2000 opened this issue Jan 9, 2020 · 7 comments
Closed

Add option to show QuickFolders tabs below main toolbar #20

RealRaven2000 opened this issue Jan 9, 2020 · 7 comments
Assignees

Comments

@RealRaven2000
Copy link
Owner

Add a new option that allows displaying the QF tabs closer to the preview area (below the main toolbar) like this:

image

@PissedFirefoxUser
Copy link

Sure hope you can make this work! Thanks for all your excellent add-ons!

@RealRaven2000
Copy link
Owner Author

In Inspector, with MenuOnTop installed, I can move the toolbar to the desired location with this:

#QuickFolders-Toolbar {
  -moz-box-ordinal-group: 40 !important;
}

I think the main thing here is to give it a higher value than the main toolbar #mail-bar3

This method should also work as a rule in userChrome.css.

@RealRaven2000
Copy link
Owner Author

Upon testing without MenuOnTop, the same rule should also work in this case as by default there is no -moz-box-ordinal-group set for #mail-bar3 - so the value counts as 0. Only MenuOnTop adds the value 30 (and maybe other Add-ons that may influence toolbar location order).

This means a high value for -moz-box-ordinal-group will work in any case and push down the QF toolbar to the bottom of the container #mail-toolbox. I think 100 should be fine.

@RealRaven2000
Copy link
Owner Author

As regards configuration UI, the Options dialog is already fairly overloaded - is it okay to hide the configuration behind the General item "Hide QuickFolders when they are not needed"? This could just open a small config window (a method I have used before for other deep configuration to unclutter QF's UI) where advanced toolbar options can be modified.

image

apart from removing clutter, I also won't have to add multi-language translation for this feature.

@RealRaven2000
Copy link
Owner Author

Below is a test version. To set the new option do the following steps

  • open QuickFolders settings, General tab
  • right-click the option Hide QuickFolders when they are not needed
  • find the setting extensions.quickfolders.toolbar.ordinalPosition and set it to 40 or a higher value.
  • close the configuration window

image

To set to normal, right-click the value to reset to its default value ( 0 ).

image

QuickFolders-min-4.18pre3.zip

@PissedFirefoxUser
Copy link

It worked perfectly!! Thank you!

@RealRaven2000
Copy link
Owner Author

Fixed in release 4.18.1 - published today (07/06/2020). Setting can be found on the Advanced tab of QuickFolders Settings.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants