Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent menu font size when dragging mail to a QuickFolders tab #329

Closed
FTKL opened this issue Dec 1, 2022 · 11 comments
Closed

Inconsistent menu font size when dragging mail to a QuickFolders tab #329

FTKL opened this issue Dec 1, 2022 · 11 comments
Assignees

Comments

@FTKL
Copy link

FTKL commented Dec 1, 2022

This problem is only visible when the button font size option under "Personalize my tabs!" has been changed to something other than the default value.
The button font size (extensions.quickfolders.buttonFontSizeN) also changes accordingly the list font size when right-clicking on the button. However, when dragging an email to the button, the list font sizes remains the default one.

Steps to replicate : change the the button font size. Drag an email to a pinned folder. Notice the difference compared to right-clicking the pinned folder.

@RealRaven2000 RealRaven2000 self-assigned this Dec 5, 2022
@RealRaven2000
Copy link
Owner

will need to investigate - sorry for the late reply

@RealRaven2000
Copy link
Owner

in my experience, the font size of the dropdown menus is never affected by the button font size - whether you drag emails to the tab or right-click it:

image

@FTKL
Copy link
Author

FTKL commented Dec 20, 2022 via email

@RealRaven2000
Copy link
Owner

Here is what I see with Button font size set on 10. When I change this value: [image: image.png] Tab font size shrinks accordingly: [image: image.png]

can you please edit your reply on github.com and paste the images there? They were not transferred by answering the email.

@FTKL
Copy link
Author

FTKL commented Dec 21, 2022 via email

@RealRaven2000
Copy link
Owner

I could reproduce the behavior now - I had tested in a test profile on Thunderbird 91 where the font size wasn't affected when you right-clicked or dragged. Indeed it is inconsistent in Thunderbird 102. (By the way it is easier to see if you set a large font size). It's a strange one as both menus are built with the same function. Maybe they are "attached" to the tabs in different ways.

@RealRaven2000
Copy link
Owner

When debugging and having a breakpoint during the drag and drop I see that the popup menu is not appended within the button element. It is appended after the last visible tab.

When right-clicking a button, the popup menu is a child of the toolbarbutton element
image

In inspector, I tried adding a rule to override font-size and a color attribute for testing:

#QuickFolders-FoldersBox popupset label {
  font-size: 14px !important;
  color: red;
}

image

this looks promising, I will add this to the code of the updateUserStyles() function that is in charge of updating the layout (blingable) elements of the toolbar. Probably need a second rule for the navigation bar (Current folder toolbar) for consistency.

@RealRaven2000 RealRaven2000 changed the title Button font size inconsistent with list size when dragging Inconsistent menu font size when dragging mail to a QuickFolders tab Dec 21, 2022
@RealRaven2000
Copy link
Owner

Here is a preview version for testing that implements the new rule to fix this inconsistency.

QuickFolders-mx-5.14.1pre24.zip

I also decided to apply the font size to the results of the quickMove search results (but not to the textbox), for consistency:

image

To test this version, download the zip file above and drag it into Thunderbird Add-ons Manager (without extracting its contents)

@RealRaven2000
Copy link
Owner

There was still an inconsistency in Thunderbird 91 (when right-clicking a QF tab, the custom font size wouldn't work) - so I added an additional specific rule for Thunderbird 91. Prerelease version below:

QuickFolders-mx-5.15pre31.zip

To test this version, download the zip file above and drag it into Thunderbird Add-ons Manager (without extracting its contents)

@RealRaven2000
Copy link
Owner

Harmonized rules so same rule can be applied to 91 and 102:

QuickFolders-mx-5.15pre33.zip

To test this version, download the zip file above and drag it into Thunderbird Add-ons Manager (without extracting its contents)

@RealRaven2000
Copy link
Owner

Implemented in 5.15.1 - Published 22/Dec/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants