Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number shortcuts not working - move mail with Option+Shift+Number #387

Open
RealRaven2000 opened this issue Aug 9, 2023 · 6 comments
Open
Assignees

Comments

@RealRaven2000
Copy link
Owner

reported by @herve-debar

I upgraded yesterday to TB 115.1.0 on Mac OS Ventura 13.5. used to be able to move messages to a quickfolder by using "OPTION+SHIFT+Number" on the selected message. This seems to not work anymore. Can you confirm and let me know if there are keyboard shortcuts to move messages to folders ? This is the primary reason for me to use QuickFolders.
Thanks !

@RealRaven2000
Copy link
Owner Author

RealRaven2000 commented Aug 9, 2023

Error thrown by the command:

Uncaught ReferenceError: MsgMoveMessage is not defined
    windowKeyPress chrome://quickfolders/content/quickfolders-interface.js:1957
    initKeyListeners chrome://quickfolders/content/quickfolders.js:672
quickfolders-interface.js:1957:17

So this function does not exist anymore. we will try to use the commandController instead, through the command cmd_moveMessage. Also we can only support CTRL+Shift+Key, because ALT (OPTION?) and CTRL without SHIFT are all taken by Thunderbird itself.

@RealRaven2000
Copy link
Owner Author

RealRaven2000 commented Aug 9, 2023

cmd_moveMessage didn't work either, so I am using some utility functions I had written:

QuickFolders-mx-6.1.2pre4.zip

if  (isShift) {
  // replacing MsgMoveMessage() function
  const makeCopy = false;
  let uris = QuickFolders.Util.getSelectedMsgUris();
  QuickFolders.Util.moveMessages(button.folder, uris, makeCopy);
}
else {
  this.onButtonClick(button,e,false);
}

image

I recommend to configure it for using CTRL(+Shift) rather than OPTION/ALT because as far as I can see Thunderbird snatched the Option+Number combos (on Windows ALT+number) away for switching between the spaces, and I cannot seem to override that behavior.


To test the version above, download the zip file, drag into Thunderbird Add-ons Manager, do not extract contents or if won't install.

@RealRaven2000
Copy link
Owner Author

I got some additional observations from a tester:

I've installed the new version of QuickFolders and the move now works. However, when an email is moved to its new tab, the message is marked "unread", not "read" as it was before it was moved.

I've noticed something else. When I move a message to tab using Shift+Ctrl+, it actually creates two copies of the message on tab . One of them is exactly as it was; the other is shown as "unread" and the "Re: " at the beginning of the subject is removed.

@RealRaven2000
Copy link
Owner Author

Added a note in 6.2 to fix in future release - Published 30/08/2023

image

@RealRaven2000 RealRaven2000 unpinned this issue Mar 28, 2024
@RealRaven2000
Copy link
Owner Author

For a workaround, you can use the Add-on tbkeys-lite

Configure it as follows:

image

@RealRaven2000
Copy link
Owner Author

Integrated a help text and link to the comment above in QuickFolders:

image

Test version:

QuickFolders-mx-6.5pre29.zip


To install version above download zip file and drag the file into Thunderbird Add-ons Manager (do not extract contents, it won't install like that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant