Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0b2 - saving template menus saves badly formatted file #247

Closed
RealRaven2000 opened this issue Jul 16, 2023 · 2 comments
Closed

4.0b2 - saving template menus saves badly formatted file #247

RealRaven2000 opened this issue Jul 16, 2023 · 2 comments
Assignees
@RealRaven2000
Labels
bug ESR 115 Changes for Thunderbird SuperNova UI

Comments

@RealRaven2000
Copy link
Owner

When modifying the list of templates, the smartTemplates.json file is saved with a bad format.

image

This is a regression caused by changes from the deprecated OS.File.writeAtomic to IOUtils - I wanted to save a prettyfied json file like before and used writeJSON but that needs the object as parameter (and not a JSON string) . This leads to a bad json file that cannot be read anymore
@RealRaven2000 RealRaven2000 added bug ESR 115 Changes for Thunderbird SuperNova UI labels Jul 16, 2023
@RealRaven2000 RealRaven2000 self-assigned this Jul 16, 2023
@RealRaven2000 RealRaven2000 mentioned this issue Jul 16, 2023
Closed
@RealRaven2000
Copy link
Owner Author

quick fix version - using writeUTF8 instead - install over the previous versions (4.0b1 or 4.0b2) and prereleases to avoid losing the templates list!

smartTemplate-fx-4.0pre273.zip

RealRaven2000 added a commit that referenced this issue Jul 17, 2023
@RealRaven2000
[issue #247] Regression - saving template menus saves invalid smartTe…
cc05f8d 
…mplates.json file.
RealRaven2000 added a commit that referenced this issue Jul 17, 2023
@RealRaven2000
[issue #247] Regression - saving template menus saves invalid smartTe…
0eadfda 
…mplates.json file. [issue #248] current recipient update
@RealRaven2000
Copy link
Owner Author

Fixed in 4.0b3; published on 17/02/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RealRaven2000 RealRaven2000

Labels
bug ESR 115 Changes for Thunderbird SuperNova UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RealRaven2000