Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Follow Up button above email preview less obtrusive #254

Closed
RealRaven2000 opened this issue Sep 8, 2023 · 6 comments
Closed

Make Follow Up button above email preview less obtrusive #254

RealRaven2000 opened this issue Sep 8, 2023 · 6 comments

Comments

@RealRaven2000
Copy link
Owner

At the moment the header button for replying / forwarding via external templates takes a lot of space.

image

There is currently no way to remove it or move it to the overflow button [More ⯆] via an API call.

Therefore I raised Bug 1851172. In the meantime I will shorten the label to only read "SmartTemplates"

@RealRaven2000
Copy link
Owner Author

RealRaven2000 commented Sep 13, 2023

To alleviate the problem, I made 2 changes:

1 - I shortened the label to "SmartTemplates"
2 - I added an option to hide the text in the "icon+text" mode; you can simply check the new option "hide label" on the bottom of the menu like this:

image

then, in icon+text mode, there will be only the icon shown, which should be less disruptive for users who don't want to use this button. This is a workaround until there is a way to hide the button permanently using the API or Thunderbird Core UI.

image

Preview version below - To do: localise the label into all 21 languages.

smartTemplate-fx-4.1.1pre18.zip


To install in Thunderbird, download the zip file above, then drag the file into Thunderbird Add-ons Manager. Do not extract the files inside or it will not install!

@RealRaven2000
Copy link
Owner Author

RealRaven2000 commented Sep 13, 2023

One more version. I forgot to hide the command "Hide Label" when the button is in "Text only" mode. In that case of course it makes no sense to not show the label text because we will then end up with an empty button (no icon, no text!)

To see the change, you may have to restart Thunderbird, as it caches style sheets, just like Firefox.

smartTemplate-fx-4.1.1pre19.zip


To install this in Thunderbird, download the zip file above, then drag the file into Thunderbird Add-ons Manager. Do not extract the files inside or it will not install!

@JoeWinograd
Copy link

I tested the pre19 update with 115.2.2 (64-bit) on W10 Pro 22H2. It installed perfectly and worked perfectly! The shortened button text is a nice improvement. I tested it with all three Button Style settings: only Icons, only Text, both Icons and Text. With only-Text and only-Icons, the Hide Label menu pick correctly does not appear. With the Icons and Text setting, the Hide Label menu pick does appear and works correctly both checked and unchecked. Great job on the workaround! Regards, Joe

@RealRaven2000
Copy link
Owner Author

Ok, I will translate and land this in the next official version! Will close the issue once it is published to addons.thunderbird.net

@JoeWinograd
Copy link

Excellent! Very much appreciated!

@RealRaven2000 RealRaven2000 changed the title Make SmartTemplates "follow up" button above email preview removable Make Follow Up button above email preview less obtrusive Sep 21, 2023
RealRaven2000 added a commit that referenced this issue Sep 24, 2023
@RealRaven2000
Copy link
Owner Author

Implemented in 4.2.1, published 25/09/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants