Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autostart assistant problems: button not highlighted when updating / starting Add-on from extension manager #210

Open
RealRaven2000 opened this issue Aug 29, 2023 · 2 comments
Assignees
Labels

Comments

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Aug 29, 2023

When we update quickFilters using the Add-ons Manager tab (e.g. through manual update or installing the extension manually, or if we activate it from there, the automatic startup doesn't fully work: the toolbar buttons will not show as red / active when switching to any folder / mail tab.

Also, after an update, when clicking the "news" panel, the button does not show as "assistant active" when it is restored to its normal looks.

@RealRaven2000
Copy link
Owner Author

These are all regressions following the radical rewrite that the Thunderbird 3pane and toolbar handling has underwent in Thunderbird 115.

At the moment the routine that listens for toolbar button changes is only in the main window overlay script;

  • the listener should be moved into a 3pane script and then decide whether it is a mail tab (where the button can be displayed in the toolbar) and then switched to "assistant active" status.
  • likewise we need a tab listener that detects when such a tab is activated and the button status needs to be updated then.
  • Finally we need to check when the new / invalid license status is removed and also update the "assistant active" state accordingly.

@RealRaven2000
Copy link
Owner Author

I found out that the function updatequickFiltersLabel() needs to badly become aware of assistant status; this way if there are any changes to the button label that follow from reading release notes, updating the license status etc. will always make sure the assistant status (red icon color, if it is active) remains visible no matter how the looks of the toolbar button are modified otherwise. I also added a new test menu item under tools to trigger the news flag which causes the button to show the "quickFilters was updated" message.

image

Here is a version that addresses most of the described issues:

quickFilters-wx-6.2.2pre10.zip

It (likely) still needs a bunch of testing for hardening...


(as usual) to test the version above, download the zip file, drag into Thunderbird Add-ons Manager, do not extract contents or if won't install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant