Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of eslint is breaking the build 🚨 #13

Closed
greenkeeper bot opened this issue Jun 26, 2018 · 2 comments
Closed

An in-range update of eslint is breaking the build 🚨 #13

greenkeeper bot opened this issue Jun 26, 2018 · 2 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Jun 26, 2018

Version 5.0.1 of eslint was just published.

Branch Build failing 🚨
Dependency [eslint](https://github.com/eslint/eslint)
Current Version 5.0.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • continuous-integration/travis-ci/push The Travis CI build failed Details
  • coverage/coveralls First build on greenkeeper/eslint-5.0.1 at 98.376% Details

Release Notes v5.0.1
  • 196c102 Fix: valid-jsdoc should allow optional returns for async (fixes #10386) (#10480) (Mark Banner)
  • 4c823bd Docs: Fix max-lines-per-function correct code's max value (#10513) (Rhys Bower)
Commits

The new version differs by 4 commits.

  • caeb223 5.0.1
  • 125dc34 Build: changelog update for 5.0.1
  • 196c102 Fix: valid-jsdoc should allow optional returns for async (fixes #10386) (#10480)
  • 4c823bd Docs: Fix max-lines-per-function correct code's max value (#10513)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 26, 2018

After pinning to 5.0.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@TemaSM
Copy link
Contributor

TemaSM commented Jun 27, 2018

Inconsistent tests are result of this peace of code. Definitely need to refactor it, so leaving this note to myself

let DbInstance = lowdb(this._adapter)
// If lowdb initiated with async (Promise) adapter
if (isPromise(DbInstance)) {
debug('DbInstance is Promise like')
// TODO: Split it from constructor, because this code will produce glitches if async initiating may take too long time
DbInstance.then((DB) => {
this.DB = DB
_initDB.call(this)
})
}
// If lowdb initiated with sync adapter
else {
this.DB = DbInstance
_initDB.call(this)
}

Described issue happened in #16.
We cannot read sessions from database immediately, cause we should wait for it to be ready.

@TemaSM TemaSM added this to the v0.0.6 milestone Jul 23, 2018
TemaSM added a commit that referenced this issue Aug 28, 2018
TemaSM added a commit that referenced this issue Aug 28, 2018
TemaSM added a commit that referenced this issue Aug 28, 2018
* Improved detection of empty session data

* ✅ Improved tests (better coverage)

* ✅ Added new tests (better coverage)
* Tests for `format.serialize` and `format.deserialize` functions of lowdb storage
* Test for `isPromise()` function
* Exporting `isPromise()` function now

* 🔧 Ignoring file `sessions.json`, which comes after running tests

* ⬆️ Upgrading dependencies

* Added .npmrc (disable package-lock.json)

* 📝 Improve documentation & JSDoc config  [ci skip]

* 💥 Default storage type: storageFileAsync -> storageFileSync, see #16

* 👌 Possible fix for #16 and #13

* 🔧 Move ESLint config from package.json to .eslintrc [ci skip]

* Fixing tests (TravisCI failing builds for Node 6)
@TemaSM TemaSM closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant