-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An in-range update of eslint is breaking the build 🚨 #13
Comments
After pinning to 5.0.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results. |
Inconsistent tests are result of this peace of code. Definitely need to refactor it, so leaving this note to myself telegraf-session-local/lib/session.js Lines 70 to 84 in 8142a6a
Described issue happened in #16. |
* Improved detection of empty session data * ✅ Improved tests (better coverage) * ✅ Added new tests (better coverage) * Tests for `format.serialize` and `format.deserialize` functions of lowdb storage * Test for `isPromise()` function * Exporting `isPromise()` function now * 🔧 Ignoring file `sessions.json`, which comes after running tests * ⬆️ Upgrading dependencies * Added .npmrc (disable package-lock.json) * 📝 Improve documentation & JSDoc config [ci skip] * 💥 Default storage type: storageFileAsync -> storageFileSync, see #16 * 👌 Possible fix for #16 and #13 * 🔧 Move ESLint config from package.json to .eslintrc [ci skip] * Fixing tests (TravisCI failing builds for Node 6)
Version 5.0.1 of eslint was just published.
[eslint](https://github.com/eslint/eslint)
This version is covered by your current version range and after updating it in your project the build failed.
eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.
Status Details
Release Notes
v5.0.1Commits
The new version differs by 4 commits.
caeb223
5.0.1
125dc34
Build: changelog update for 5.0.1
196c102
Fix: valid-jsdoc should allow optional returns for async (fixes #10386) (#10480)
4c823bd
Docs: Fix max-lines-per-function correct code's max value (#10513)
See the full diff
FAQ and help
There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper Bot 🌴
The text was updated successfully, but these errors were encountered: