Merge pull request #14 from RealistikOsu/bcrypt-md5-cache

fix: use bcrypt: md5 cache instead of userid: md5

helpers/user_helper.py

@@ -29,21 +29,20 @@ def verify_password(user_id: int, password: str) -> bool:
         password (str): The user's password hashed with MD5.
     """
 
-    # Check if we already cached them, for speed benefit.
-    passw = glob.cached_passwords.get(user_id)
-    if passw:
-        return password == passw
-
-    # Nope. Sad. Bcrypt time.
     passw_db = glob.db.fetch(
         "SELECT password_md5 FROM users WHERE id = %s LIMIT 1",
         (user_id,),
     )["password_md5"]
 
+    # Check if we already cached them, for speed benefit.
+    if passw_db in glob.cached_passwords:
+        return glob.cached_passwords[passw_db] == password
+
     res = bcrypt.checkpw(password.encode(), passw_db.encode())
     # Cache it for later
     if res:
-        glob.cached_passwords[user_id] = password
+        glob.cached_passwords[passw_db] = password
+
     return res
 
 

objects/glob.py

@@ -32,7 +32,7 @@
 tokens = TokenList()
 channels = ChannelList()
 matches = MatchList()
-cached_passwords: dict = {}
+cached_passwords: dict[str, str] = {}
 chatFilters = None
 pool: ThreadPool
 busyThreads = 0