Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from @/deepmerge DENOIFY: DEPENDENCY UNMET (BUILTIN) #84

Closed
chmac opened this issue Mar 14, 2022 · 2 comments · Fixed by #85
Closed

Import from @/deepmerge DENOIFY: DEPENDENCY UNMET (BUILTIN) #84

chmac opened this issue Mar 14, 2022 · 2 comments · Fixed by #85
Labels
Resolution: Fixed The issue has been fixed. Status: Released It's now live. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.

Comments

@chmac
Copy link

chmac commented Mar 14, 2022

Bug Report

This line is throwing in deno:

import type { DeepMergeMergeFunctionsDefaults } from "@/deepmerge DENOIFY: DEPENDENCY UNMET (BUILTIN)";

Expected behavior

Expect it to Just Work™ :-)

Actual behavior

error: Relative import path "@/deepmerge DENOIFY: DEPENDENCY UNMET (BUILTIN)" not prefixed with / or ./ or ../
    at https://deno.land/x/deepmergets@v4.0.0/dist/deno/types/options.ts:1:54

Steps to reproduce

Import this into a deno project

Proposed changes

I guess the import is supposed to be ../deepmerge.ts but I suspect you're using a build process to build the deno version and so it seems like that needs to be fixed?

@chmac chmac added Status: Triage This issue needs to be triaged. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors. labels Mar 14, 2022
@chmac
Copy link
Author

chmac commented Mar 14, 2022

For any other impatient souls, I hot fixed this and it seems to work for me like so:

export { deepmerge } from "https://raw.githubusercontent.com/GenerousLabs/deepmerge-ts/3004e954dd06bfc3e2aaf7c98bc97a50c635fb10/dist/deno/mod.ts";

@RebeccaStevens RebeccaStevens added Resolution: Fixed The issue has been fixed. and removed Status: Triage This issue needs to be triaged. labels Mar 14, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Fixed The issue has been fixed. Status: Released It's now live. Type: Bug Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants