fix(plugin-commitlint): handling of parserPreset when it's not a st…

…ring fix webpro-nl#631
RebeccaStevens · May 12, 2024 · d581ae5 · d581ae5
1 parent fcee3ee
commit d581ae5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/packages/knip/src/plugins/commitlint/index.ts b/packages/knip/src/plugins/commitlint/index.ts
@@ -18,16 +18,23 @@ const config = [
   'package.json',
 ];
 
-const resolveConfig: ResolveConfig<CommitLintConfig> = config => {
+const resolveConfig: ResolveConfig<CommitLintConfig> = async config => {
   const extendsConfigs = config.extends
     ? [config.extends]
         .flat()
         .map(id => (id.startsWith('@') || id.startsWith('commitlint-config-') ? id : `commitlint-config-${id}`))
     : [];
   const plugins = config.plugins ? [config.plugins].flat().filter(s => typeof s === 'string') : [];
   const formatter = config.formatter ? [config.formatter] : [];
-  const parserPreset = config.parserPreset ? [config.parserPreset] : [];
-  return [...extendsConfigs, ...plugins, ...formatter, ...parserPreset];
+  const parserPreset = await config.parserPreset;
+  const parserPresetPaths: string[] = parserPreset
+    ? typeof parserPreset === 'string'
+      ? [parserPreset]
+      : parserPreset.path
+        ? [parserPreset.path ?? parserPreset]
+        : []
+    : [];
+  return [...extendsConfigs, ...plugins, ...formatter, ...parserPresetPaths];
 };
 
 export default {

diff --git a/packages/knip/src/plugins/commitlint/types.ts b/packages/knip/src/plugins/commitlint/types.ts
@@ -2,5 +2,11 @@ export type CommitLintConfig = {
   extends?: string | string[];
   plugins?: string[];
   formatter?: string;
-  parserPreset?: string;
+  parserPreset?: string | ParserPreset | Promise<ParserPreset>;
+};
+
+type ParserPreset = {
+  name?: string;
+  path?: string;
+  parserOpts?: unknown;
 };