Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate findByOfficialName and findByCommonName of CountryRepository #10

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Deprecate findByOfficialName and findByCommonName of CountryRepository #10

merged 1 commit into from
Sep 4, 2020

Conversation

slavcodev
Copy link
Contributor

No description provided.

@slavcodev slavcodev self-assigned this Sep 4, 2020
@slavcodev slavcodev marked this pull request as ready for review September 4, 2020 13:14
@slavcodev slavcodev requested a review from a team as a code owner September 4, 2020 13:14
@slavcodev slavcodev force-pushed the deprecate-too-maney-find-names branch from 5b49a81 to 98f53e6 Compare September 4, 2020 13:20
@github-actions
Copy link

github-actions bot commented Sep 4, 2020

Coverage Report

Totals Coverage
Statements: 95.69% ( 111 / 116 )
Methods: 92.31% ( 36 / 39 )

@slavcodev
Copy link
Contributor Author

php please review

@slavcodev slavcodev merged commit b01aa7f into master Sep 4, 2020
@slavcodev slavcodev deleted the deprecate-too-maney-find-names branch September 4, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashkarpetin ashkarpetin ashkarpetin approved these changes

Assignees

@slavcodev slavcodev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slavcodev @ashkarpetin