Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: support forks #50

Merged
merged 4 commits into from
Sep 12, 2023
Merged

fix!: support forks #50

merged 4 commits into from
Sep 12, 2023

Conversation

Weetbix
Copy link
Collaborator

@Weetbix Weetbix commented Sep 12, 2023

Follow up to @npentrel 's PR here: #49 馃檶

Overall changes the action to rely on the @actions/checkout action to fetch the git history and use the commit shas. Previously it would fetch manually using git inside the action, and fetch from origin which breaks for fork PRs.

Additions:

  • Update readme to specify fetch-depth: 0 when using checkout, so that the action has access to the git history
    • Update test workflow
  • Add light logging of what the action is doing

I will release as a breaking change as we no longer fetch in the action.

fixes #48
supersedes #49

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Overall readability score: 31.93 (馃煝 +0)

File Readability
README.md 56.32 (馃煝 +0)
View detailed metrics

馃煝 - Shows an increase in readability
馃敶 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
README.md 56.32 45.05 9.43 14.7 12.93 6.86
馃煝 +0 馃煝 +0 馃煝 +0 馃煝 +0 馃煝 +0 馃煝 +0

Averages:

Readability FRE GF ARI CLI DCRS
Average 31.93 16.05 14.96 15.45 15.06 8.73
馃煝 +0 馃煝 +0 馃煝 +0 馃煝 +0 馃煝 +0 馃煝 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@Weetbix Weetbix changed the title wip: support forks fix!: support forks Sep 12, 2023
@Weetbix Weetbix marked this pull request as ready for review September 12, 2023 04:07
@Weetbix Weetbix requested review from a team and noon-dawg September 12, 2023 04:07
@Weetbix Weetbix merged commit 1e49690 into main Sep 12, 2023
5 checks passed
@Weetbix Weetbix deleted the jh/support-forks branch September 12, 2023 11:17
@npentrel
Copy link
Contributor

Thanks folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action does not work for forks because it assumes origin when fetching
4 participants