Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pretty-print formatting of negative amount of money #4

Merged
merged 5 commits into from
Mar 4, 2019
Merged

Improve pretty-print formatting of negative amount of money #4

merged 5 commits into from
Mar 4, 2019

Conversation

VladimirBerdnik
Copy link

This pull request fixes pretty-print formatting for negative amount of money.

Now It formats -39.95 USD as -$39.95 instead of $-39.95

@VladimirBerdnik VladimirBerdnik requested review from adamaltman and a team and removed request for adamaltman March 4, 2019 07:37
@VladimirBerdnik VladimirBerdnik self-assigned this Mar 4, 2019
adamaltman
adamaltman approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@adamaltman adamaltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@VladimirBerdnik VladimirBerdnik merged commit 812b419 into master Mar 4, 2019
@VladimirBerdnik VladimirBerdnik deleted the GWY-10974-improve-pretty-print-formatting branch March 4, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavcodev slavcodev slavcodev approved these changes

@adamaltman adamaltman adamaltman approved these changes

@XaosSintez XaosSintez XaosSintez approved these changes

Assignees

@VladimirBerdnik VladimirBerdnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@VladimirBerdnik @slavcodev @adamaltman @XaosSintez @VladimirRebilly