Replace non-existing parameter baseUrl with correct base_uri #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test php 7.2 * Update .travis.yml
… setup properties (#291) * Update CHANGELOG * Fix resource factory on populate resources * Add plan pricing model * Add recurring interval model * Add plan trial and setup models * Update Plan to latest spec * Change CHANGELOG * Remove declare usage * Improve readibility of tests * Fix tests * Replace constant array with method ()Darray const is not supported in php5.5
* Update library dependents * Downgrade version to support php 5.6 * Fix cs * update travis to check only new PHP versions * Upgrade cs-fixer to v2.0 * Update cs-fixer config to support v2 * Disable cs-fixer temporary * Add php 7.3 to test * Fix .travis
* Upgrade PhpUnit to v7.3 * Fix tests to last version * Fix ResourceTest
* Fix code style * Enable back the cs-fixer in travis * Upgrade PhpUnit to v7.3 * Fix tests to last version * Fix ResourceTest * Fix tests after changing cs * Fix Rate cs
* Refactor LeadSources usage * Only remove unnecessary lead sources in this PR * Fix codestyle * Add changelog * Add formatting
* Remove deprecated attributes and a bit order methods * Refactor Subscription * Add SubscriptionTest * Add items to Subscriptions * Refactor SubscriptionTest * Update CHANGELOG * Add fake generator for new property * Fix CS * Add PlanItemTest
* Adjust LeadSource to latest changes * Redo test * Remove wrong imports * Fix test * Add changelog * Remove ipAddress
* Add missing coupons restriction * Small fix
* Remove Lead Sources from Subscriptions, Transactions, Invoices (#289) * Refactor LeadSources usage * Only remove unnecessary lead sources in this PR * Fix codestyle * Add changelog * Add formatting * Add plan items property to Subscription, remove deprecated ones (#297) * Remove deprecated attributes and a bit order methods * Refactor Subscription * Add SubscriptionTest * Add items to Subscriptions * Refactor SubscriptionTest * Update CHANGELOG * Add fake generator for new property * Fix CS * Add PlanItemTest * Adjust LeadSource to latest changes (#298) * Adjust LeadSource to latest changes * Redo test * Remove wrong imports * Fix test * Add changelog * Remove ipAddress * Add getCustomer in Transaction (#299) * Remove EmailNotifications code (#300) * Adjust CHANGELOG.md file (#301) * Remove LeadSources endpoint and service (#296) * Add missing coupons restriction (#302) * Add missing coupons restriction * Small fix * Remove deprecated initialInvoiceId property from Subscription (#303) * Remove declartions of strict mode * Fix tests * Remove const visibility
* Update CHANGELOG * Increase SDK version
* Adjust PhpDoc * Optimize imports * Remove unused import * Add copyright header, remove 'strict_types' directive * Reorder imports * Adjust PhpDoc
* Add shipping rates * Remove shipping zones * Update changelog * Remove shippingZones from serviceTest
* Add DOB property to the Address entity * Update fixtures * Add comment
* Add ReadyToPay * Refactor code
* Add missing properties to Subscription * Fix test * Update src/Entities/Shipping.php Co-authored-by: Vladimir Berdnik <vladimir.berdnik@rebilly.com> * Update src/Entities/Subscription.php Co-authored-by: Vladimir Berdnik <vladimir.berdnik@rebilly.com>
* Add shipping to Invoice * Update shipping schema * Add tax to invoice * Add setter * Fix factory * Update changelog * Fix test * Fix test * Fix test * Update CHANGELOG.md Co-authored-by: Simon <ninjasimon@users.noreply.github.com> * Update src/Entities/InvoiceTax.php Co-authored-by: Vladimir Berdnik <vladimir.berdnik@rebilly.com> Co-authored-by: Simon <ninjasimon@users.noreply.github.com> Co-authored-by: Vladimir Berdnik <vladimir.berdnik@rebilly.com>
* Add jobTitle to the address resource * Fix test
Coverage Report
|
slavcodev
reviewed
Sep 2, 2022
| @@ -41,7 +41,7 @@ use Rebilly\Client; | |||
| // Instantiate Rebilly client. | |||
| $client = new Client([ | |||
| 'apiKey' => ApiKeyProvider::env(), | |||
| 'baseUrl' => Client::SANDBOX_HOST, | |||
| 'base_uri' => Client::SANDBOX_HOST, | |||
There was a problem hiding this comment.
This seems incorrect. The correct property name is baseUrl
Line 224 in 6cd1f9b
There was a problem hiding this comment.
Base branch was incorrect. Please ignore.
nanobash
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.guzzlephp.org/en/stable/quickstart.html