Algolia page numbers are 0 indexed, this caters for that. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So yeh. As the title says. Algolias page numbers are 0 indexed. No joke. Page 1 = page0. Kinda like our current project versioning xD. This makes sure that we always pass page -1 to aloglia for searching so we never miss out on any results. I am hoping this will solve much oddness.
llexical
requested review from
domitriusclark,
magnificode and
racedale
as code owners
So the number of pages it returns is correct. Just the last page is the the number of pages -1. As it is 0 indexed. SO now searching is setup to always do -1 we should all be getting an extra page back and more sensible results :D.
magnificode
approved these changes
Jun 11, 2020
|
This is gonna become a crucial test we should write after launch |
💯 - can we write out an issue in GH / Trello to track this? |
magnificode
deleted the
hotfix/algolia-search-not-showing-expected-results
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So yeh. As the title says. Algolias page numbers are 0 indexed. No joke.
Page 1 = page0. Kinda like our current project versioning xD.
This makes sure that we always pass page -1 to aloglia for searching so
we never miss out on any results. I am hoping this will solve much
oddness.