[Date] [Datetime] [Timestamp] Handle QUARTER, WEEK(DAY), ISOWEEK
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohaibbq
requested review from
a team,
ageiduschek,
colincadams,
ethan-oro and
recidinick
recidinick
approved these changes
Apr 3, 2024
ageiduschek
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of bugfixes here!
0001-01-01-9999-12-31now supported. PreviouslydateValueFromLiteralhitint64caps due to thetime.Hourmultiplication occurring before we divided it bytime.Second.QUARTERsupport forDATE_ADDWEEK,WEEK(DAY OF WEEK)support forDATE_DIFF,DATE_TRUNCISOWEEK,ISOYEAR,QUARTERsupport forDATE_TRUNCMost date function logic has been de-duplicated and now
DATETIMEandTIMESTAMPfunctions defer toDATEmethods for date parts at the day level or higher.