[Bug] Fix link from Help Center to Agency Dashboards for production users #1068
Conversation
| import React, { PropsWithChildren } from "react"; | ||
|
|
||
| import { useStore } from "../../stores"; | ||
|
|
||
| export const LinkToPublisher: React.FC< | ||
| PropsWithChildren & { publisherPath: string } | ||
| > = ({ publisherPath, children }) => { | ||
| > = observer(({ publisherPath, children }) => { |
There was a problem hiding this comment.
Wrapping these components with the observer higher-order component is the only change in this PR - the rest is prettier formatting.
Yeah since playtesting links are technically staging, this makes sense. So hopefully this change is all that is needed once deployed to prod! |
Thank you so much, Michelle! Yeah, I was hoping for the one without the |
Description of the change
I noticed a bug when I was playing around with the Help Center in production specifically in the link to Agency Dashboards. I was taken to the staging URL which resulted in an error - instead of the production URL. For some reason the piece of logic that creates the URL based on the environment isn't picking up on the right environment. I suspect it is because when this component is mounted, the
api.environmentis firstundefineduntil it is set - and since these components aren'tobservers they might not have been re-rendering whenapi.environmentis set and have thus defaulted to the staging URL.I tried to log the
api.environmentand deploy to playtesting with and without theobserverand it loggedstagingfor both - so my hunch might be off. But regardless, both components should be wrapped in anobserver- so this change is necessary. I am curious to see when we deploy to prod if this fixes it. If not, I'll keep digging into this.Related issues
Closes #1067
Checklists
Development
This box MUST be checked by the submitter prior to merging:
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: