Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agency Dashboard][Bug] Fix linking to Category Overview page #1311

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Apr 24, 2024

Description of the change

Fix linking to Category Overview page from an agency's main dashboard page by including the agency id in the path.

Tested by running locally against staging env and ensuring linking to the Category Overview page works as intended.

Main vs this branch:

Screen.Recording.2024-04-24.at.9.04.32.AM.mov

Related issues

Closes #XXXX

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@helperbot-recidiviz
Copy link
Collaborator

@mxosman Playtest deployment failed. See workflow failure logs at https://github.com/Recidiviz/justice-counts/actions/runs/8817936610

Copy link
Contributor

@nichelle-hall nichelle-hall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, Mahmoud! You're a superhero!

@mxosman
Copy link
Contributor Author

mxosman commented Apr 24, 2024

No, you are! Thank you for the quick approval, Nichelle!

@mxosman mxosman merged commit 508c241 into main Apr 24, 2024
8 of 10 checks passed
@mxosman mxosman deleted the mahmoud/fix-linking branch April 24, 2024 14:08
@morden35
Copy link
Contributor

wicked fast! thank you Mahmoud!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants