Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publisher] Set Up Metrics: Add metric and dimension descriptions in definition modal #1324

Merged
merged 3 commits into from
May 2, 2024

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented May 1, 2024

Description of the change

Add metric and dimension descriptions in metric definition modals.

Screen.Recording.2024-05-02.at.8.10.39.AM.mov

Related issues

Closes #1307

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman requested review from morden35, lilidworkin and a team May 2, 2024 13:14
Copy link
Contributor

@morden35 morden35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is lovely!

@mxosman mxosman merged commit 29ceed7 into main May 2, 2024
7 checks passed
@mxosman mxosman deleted the mahmoud/1307-add-metric-desc-in-definition-modals branch May 2, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Publisher] Add metric descriptions in definition popup
2 participants