Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publisher][Bug] Fix link to Uploaded Files #1343

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented May 22, 2024

Description of the change

Fix broken link to Uploaded Files component from menu dropdown and minor styling updates so it doesn't look off as a standalone page.

Screenshot 2024-05-22 at 3 48 28 PM

Type of change

All pull requests must have at least one of the following labels applied (otherwise the PR will fail):

Label Description
Type: Bug non-breaking change that fixes an issue
Type: Feature non-breaking change that adds functionality
Type: Breaking Change fix or feature that would cause existing functionality to not work as expected
Type: Non-breaking refactor change addresses some tech debt item or prepares for a later change, but does not change functionality
Type: Configuration Change adjusts configuration to achieve some end related to functionality, development, performance, or security
Type: Dependency Upgrade upgrades a project dependency - these changes are not included in release notes

Related issues

Closes #1342

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@mxosman mxosman requested a review from a team May 22, 2024 20:49
Copy link
Contributor

@morden35 morden35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight fire

@mxosman
Copy link
Contributor Author

mxosman commented May 23, 2024

@mxosman mxosman merged commit 86010ea into main May 23, 2024
8 checks passed
@mxosman mxosman deleted the mahmoud/fix-uploaded-files branch May 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Publisher][Bug] Fix broken link to Uploaded Files and update styling
2 participants