Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Proxy Paths #42

Merged
merged 1 commit into from Sep 27, 2022
Merged

Adjust Proxy Paths #42

merged 1 commit into from Sep 27, 2022

Conversation

mxosman
Copy link
Contributor

@mxosman mxosman commented Sep 26, 2022

Description of the change

Adjusts the path in the setupProxy.js to ["/api", "/app_public_config.js"] as that seems to fix some strange issue with proxying and connecting to the backend.

Related issues

Closes #XXXX

Checklists

Development

This box MUST be checked by the submitter prior to merging:

  • Double- and triple-checked that there is no Personally Identifiable Information (PII) being mistakenly added in this pull request

These boxes should be checked by the submitter prior to merging:

  • Tests have been written to cover the code changed/added as part of this pull request

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@lilidworkin
Copy link
Collaborator

Amazing! I'm going to let @nichelle-hall test this and then accept if it works for her!

@nichelle-hall
Copy link
Contributor

LGTM! Tested locally and it worked for me :)

@mxosman mxosman merged commit f11b226 into main Sep 27, 2022
@mxosman mxosman deleted the mahmoud/proxy branch September 27, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants