Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Feature #84

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Settings Feature #84

merged 3 commits into from
Oct 27, 2022

Commits on Oct 26, 2022

  1. Settings: Scaffolding (#59)

    * Restructure settings files, rename, extract styles
    
    * Refactor settings page and set up existing components in new structure
    
    * Styling adjustment
    
    * Change text to Your Account
    
    * Settings: Metric Configuration (1/n) (#64)
    
    * Initial work on metric config refactor in settings
    
    * Continue iterating on refactor up to the breakdown page
    
    * Remove routing to old metrics page - remove from menu
    
    * Styling adjustment
    
    * Fix key warning
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    
    Settings: Metric Configuration: Metric Details & Breakdowns (2/n) (#66)
    
    * Initial work on metric config refactor in settings
    
    * Continue iterating on refactor up to the breakdown page
    
    * Styling adjustment
    
    * Change MetricView to MetricConfiguration and update all imports - remove MetricViewMocks
    
    Restyle metric details up to breakdown dimensions
    
    New breakdown copy
    
    Refactor breakdowns with toggles
    
    * Refactor disaggregations to use checkboxes and remove toggle switch
    
    * Add definitions panel, add icon
    
    * Style clean up - comments
    
    * Clean up
    
    * Feedback: reduce height in metric boxes, only use filteredMetricSettings optimization
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    
    Settings: Metric Configuration: Definitions (3/n) (#83)
    
    * Initial work on MetricDefinitions component
    
    * Continue fleshing out definitions component, move metric context config to overall metric definition panel, set up mocks for definitions, add and update types, fix adjustments dependent on changes
    
    * Adjust styles for scrolling
    
    * Clean up
    
    * Style and comment clean up
    
    * Fix type
    
    * Use undefined vs empty string
    
    * Fix key warning
    
    * Settings: Metric Configuration: Navigation (Table of Contents) (4/n)  (#85)
    
    * Add table of contents navigation when inside of metric details, move shared state to settings page and pass state to menu and metric config, fix disaggregation issues, add styling for table of contents, fix bug in mocks, add types, various adjustments to accommodate new change
    
    * Clean up
    
    * Add comments
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    
    Settings: Metric Configuration: Refactor & Clean Up (5/n) (#91)
    
    * Major clean up - separate components into their own files
    
    * Fix dimension bug
    
    * Fix switch agency bug
    
    * Minor clean up
    
    * Merge types with existing types and update all connected components
    
    * Clean up
    
    * Handle cases when settings array is empty or non-existent
    
    * Handle cases when settings array is empty or non-existent
    
    * Styling adjustments per prev feedback
    
    * Recreate MetricsView Component for Data Visualization (#101)
    
    * Recreate old MetricsView component
    Update route and add to menu
    Update styling
    Remove unnecessary code - minor refactor
    Clean up
    
    * Fix styling issue
    
    * Add spacing between header and data viz
    
    * Add border top to data viz dropdown
    
    * Update tooltip and link to direct users to Settings to change metric config
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    
    Settings: Metric Configuration: Save Definitions (and Replace Mocks) (6/n) (#108)
    
    * [Summary] Remove mocks and implement definition saving functionality and UI update functionality
    
    * Revert to default values functionality
    
    * Fix revert to default for metric setting
    
    * Clean up comment
    
    * PR feedback: reverse the conditionals
    
    * Settings: Metric Configuration: Playtesting Followups - Misc. Styling Adjustments (1/n) (#110)
    
    * Remove tabs in metric list when agency has only one system
    
    * Change casing to capitalized case on Monthly Annual badges
    
    * Reduce spacing of Settings menu
    
    * Scroll gap adjustment
    
    * Settings: Metric Configuration: Playtesting Followups - Selection States (2/n) (#112)
    
    * Add arrow vector, add logic for persisting on click, update hover and active states, clean up
    
    * Settings: Metric Configuration: Playtesting Followups - Default Definition Hover State (3/n) (#113)
    
    * Add hover feature to display the default settings when user hovers over the revert button
    
    * Update to Choose instead of Revert per design
    
    * Clean up
    
    * Settings: Metric Configuration: Playtesting Followups - Enable Dimension Selection When Disaggregation is Off (4/n)  (#115)
    
    * When disaggregation and dimensions are all off, checking on a dimension will turn on the disaggregation
    
    * Styling bug fixes
    
    * Implement responsiveness per design (#117)
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    2 people authored and Mahmoud committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    77779ac View commit details
    Browse the repository at this point in the history
  2. Rebase adjustments - updating imports, types and other react upgrade …

    …related adjustments
    Mahmoud authored and Mahmoud committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    814987a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Settings: Metric Configuration: Playtesting Followups - Misc. Styling…

    … Adjustments (6/n) (#121)
    
    * Fix overflow scroll bars
    
    * Adjust overall spacing and font size, fix squished arrow in metric box
    
    * Adjust Context and update copy for items without tech definition
    
    Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    mxosman and Mahmoud committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    dfd7bd9 View commit details
    Browse the repository at this point in the history