Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Metric Configuration: Refactor & Clean Up (5/n) #91

Merged
merged 10 commits into from
Oct 20, 2022
Merged

Settings: Metric Configuration: Refactor & Clean Up (5/n) #91

merged 10 commits into from
Oct 20, 2022

Commits on Oct 18, 2022

  1. Major clean up - separate components into their own files

    Mahmoud authored and Mahmoud committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    15ceea0 View commit details
    Browse the repository at this point in the history

  2. Fix dimension bug

    Mahmoud authored and Mahmoud committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    7571c39 View commit details
    Browse the repository at this point in the history

  3. Fix switch agency bug

    Mahmoud authored and Mahmoud committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    c627a95 View commit details
    Browse the repository at this point in the history

  4. Minor clean up

    Mahmoud authored and Mahmoud committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    e263691 View commit details
    Browse the repository at this point in the history

  5. Merge types with existing types and update all connected components

    Mahmoud authored and Mahmoud committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    b4b27e3 View commit details
    Browse the repository at this point in the history

  6. Clean up

    Mahmoud authored and Mahmoud committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    c4798d7 View commit details
    Browse the repository at this point in the history

  7. Handle cases when settings array is empty or non-existent

    Mahmoud authored and Mahmoud committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    e0495ec View commit details
    Browse the repository at this point in the history

  8. Handle cases when settings array is empty or non-existent

    Mahmoud authored and Mahmoud committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    fb5c536 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Styling adjustments per prev feedback

    Mahmoud authored and Mahmoud committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    da25792 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Recreate MetricsView Component for Data Visualization (#101) 

    * Recreate old MetricsView component
Update route and add to menu
Update styling
Remove unnecessary code - minor refactor
Clean up

* Fix styling issue

* Add spacing between header and data viz

* Add border top to data viz dropdown

* Update tooltip and link to direct users to Settings to change metric config

Co-authored-by: Mahmoud <mahmoud@Mahmouds-MBP.cable.rcn.com>
    @mxosman
    mxosman and Mahmoud committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    6c85f6f View commit details
    Browse the repository at this point in the history