say "deselect all" in menu when applicable

Recidiviz · Nov 10, 2020 · 1df087e · 1df087e
1 parent 7f0851c
commit 1df087e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/public-dashboard-client/src/controls/CohortSelect.js b/public-dashboard-client/src/controls/CohortSelect.js
@@ -98,8 +98,10 @@ function CustomSelect({
   selected,
   setSelected,
 }) {
+  const selectAllLabel =
+    selected.length === optionsFromData.length ? "Deselect all" : "Select all";
   const visibleOptions = [
-    { id: SELECT_ALL_ID, label: "Select all" },
+    { id: SELECT_ALL_ID, label: selectAllLabel },
     ...optionsFromData,
   ];
 

diff --git a/public-dashboard-client/src/controls/CohortSelect.test.js b/public-dashboard-client/src/controls/CohortSelect.test.js
@@ -216,6 +216,7 @@ test("supports select-all", () => {
   const { getByRole } = openMenu();
   const selectAll = getByRole("option", { name: /select all/i });
 
+  expect(selectAll).toHaveTextContent(/deselect all/i);
   act(() => userEvent.click(selectAll));
 
   // de-selects all
@@ -225,6 +226,7 @@ test("supports select-all", () => {
       "false"
     );
   });
+  expect(selectAll).toHaveTextContent(/(?<!de)select all/i);
 
   // click again to select all
   act(() => userEvent.click(selectAll));
@@ -234,6 +236,7 @@ test("supports select-all", () => {
       "true"
     );
   });
+  expect(selectAll).toHaveTextContent(/deselect all/i);
 
   // now de-select some manually and try again
   testOptions.slice(2, 6).forEach((opt) => {
@@ -244,6 +247,8 @@ test("supports select-all", () => {
     );
   });
 
+  expect(selectAll).toHaveTextContent(/(?<!de)select all/i);
+
   act(() => userEvent.click(selectAll));
   // everything is selected again
   testOptions.forEach((opt) => {
@@ -252,4 +257,5 @@ test("supports select-all", () => {
       "true"
     );
   });
+  expect(selectAll).toHaveTextContent(/deselect all/i);
 });