always show highlighted cohort (totals only)

Recidiviz · Nov 13, 2020 · 7e0217a · 7e0217a
1 parent beceb67
commit 7e0217a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/public-dashboard-client/src/viz-recidivism-rates/VizRecidivismRates.js b/public-dashboard-client/src/viz-recidivism-rates/VizRecidivismRates.js
@@ -52,7 +52,12 @@ function prependZero(records) {
  * Otherwise (i.e., a single cohort and some dimensional breakdown is selected),
  * will return one data series per demographic subgroup.
  */
-function prepareChartData({ data, dimension, selectedCohorts }) {
+function prepareChartData({
+  data,
+  dimension,
+  highlightedCohort,
+  selectedCohorts,
+}) {
   const showDemographics =
     selectedCohorts &&
     selectedCohorts.length === 1 &&
@@ -98,6 +103,10 @@ function prepareChartData({ data, dimension, selectedCohorts }) {
         if (!selectedCohorts) {
           return true;
         }
+        // highlighted cohort is included even if it's not selected
+        if (highlightedCohort && highlightedCohort.label === record.label) {
+          return true;
+        }
         return selectedCohorts.some(({ id }) => id === record.label);
       })
   );
@@ -109,6 +118,7 @@ export default function VizRecidivismRates({
   const chartData = prepareChartData({
     data: recidivismRates,
     dimension,
+    highlightedCohort,
     selectedCohorts,
   });
 

diff --git a/public-dashboard-client/src/viz-recidivism-rates/VizRecidivismRates.test.js b/public-dashboard-client/src/viz-recidivism-rates/VizRecidivismRates.test.js
@@ -83,6 +83,22 @@ test("renders one line per cohort", () => {
   expect(getMainByLabelText("7 lines in a line chart")).toBeVisible();
 });
 
+test("renders the highlighted cohort even if it's not selected", () => {
+  const dimension = DIMENSION_KEYS.total;
+
+  render(
+    <VizRecidivismRates
+      data={{
+        dimension,
+        highlightedCohort: allSelectedCohorts[8],
+        recidivismRates: recidivismRatesFixture,
+        selectedCohorts: allSelectedCohorts.slice(0, 5),
+      }}
+    />
+  );
+  expect(getMainByLabelText("6 lines in a line chart")).toBeVisible();
+});
+
 test("renders one line per demographic subgroup", () => {
   const dimension = DIMENSION_KEYS.race;
   render(