preserve demographic view when switching between single years

Recidiviz · Nov 17, 2020 · f8c38cc · f8c38cc
1 parent c846614
commit f8c38cc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/public-dashboard-client/src/page-prison/PagePrison.js b/public-dashboard-client/src/page-prison/PagePrison.js
@@ -101,7 +101,12 @@ export default function PagePrison() {
   // doing this inside the render loop rather than in an effect
   // to prevent an intermediate state from flashing on the chart;
   // the current value check avoids an infinite render loop
-  if (!singleCohortSelected && recidivismDimension !== DIMENSION_KEYS.total) {
+  if (
+    !singleCohortSelected &&
+    // we don't need to reset the dimension if no cohorts are selected
+    selectedCohorts.length > 1 &&
+    recidivismDimension !== DIMENSION_KEYS.total
+  ) {
     setRecidivismDimension(DIMENSION_KEYS.total);
   }
 

diff --git a/public-dashboard-client/src/viz-recidivism-rates/VizRecidivismRates.js b/public-dashboard-client/src/viz-recidivism-rates/VizRecidivismRates.js
@@ -60,7 +60,7 @@ function prepareChartData({
 }) {
   const showDemographics =
     selectedCohorts &&
-    selectedCohorts.length === 1 &&
+    selectedCohorts.length <= 1 &&
     dimension !== DIMENSION_KEYS.total;
 
   const filteredData = data.filter(recordIsTotalByDimension(dimension));