Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[US_ID][Pre-launch] Fix broken Sentencing and Probation "Judicial District" dropdowns (or remove them) #582

Closed
lilidworkin opened this issue Jul 18, 2022 · 1 comment · Fixed by #588

Comments

@lilidworkin
Copy link
Contributor

lilidworkin commented Jul 18, 2022

Describe the bug
All Judicial District dropdowns on the Sentencing and Probation narratives don't work. This is because they both reference the judicialDistricts variable, which is empty.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://spotlight-staging.recidiviz.org/us-id/narratives/sentencing/1 or https://spotlight-staging.recidiviz.org/us-id/narratives/probation/1
  2. Click on any Judicial District dropdown

Expected behavior
You can select different Judicial Districts.

Additional context
I think this is because our metric files for Sentencing and Probation don't contain complete district information. You can see the metric files in GCS here. For instance, sentence_type_by_district_by_demographics.json only has values of ALL or EXTERNAL_UNKNOWN for the district field. Once we update the pipelines that generate these files, we can update us_id.ts accordingly.

If it's difficult to add this data, we should just remove this dropdown.

@lilidworkin lilidworkin changed the title [US_ID][Pre-launch] Fix broken Judicial District dropdowns (or remove them) [US_ID][Pre-launch] Fix broken Sentencing and Probation "Judicial District" dropdowns (or remove them) Jul 18, 2022
@lilidworkin lilidworkin added this to To do in Spotlight V2 Follow-Ups via automation Jul 18, 2022
@jkgerig
Copy link

jkgerig commented Jul 18, 2022

Not high priority for ID leadership, we should just remove this option.

@terryttsai terryttsai moved this from To do to In progress in Spotlight V2 Follow-Ups Jul 19, 2022
Spotlight V2 Follow-Ups automation moved this from In progress to Done Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants