Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide locality filter dropdown if there are no dropdown options #588

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

terryttsai
Copy link
Contributor

@terryttsai terryttsai commented Jul 19, 2022

Description of the change

We are launching Idaho without breaking down locality by judicial districts, so hide the locality dropdown option in Idaho.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #582

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Jul 20, 2022

Pull Request Test Coverage Report for Build 2699533585

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 83.602%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spotlight-client/src/LocalityFilterSelect/LocalityFilterSelect.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 2699521852: -0.04%
Covered Lines: 2081
Relevant Lines: 2353

💛 - Coveralls

@terryttsai terryttsai merged commit 1a8a1be into main Jul 20, 2022
@terryttsai terryttsai deleted the terry/hide-empty-filter-dropdown branch July 20, 2022 20:05
@terryttsai terryttsai restored the terry/hide-empty-filter-dropdown branch July 20, 2022 20:05
@terryttsai terryttsai deleted the terry/hide-empty-filter-dropdown branch July 20, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US_ID][Pre-launch] Fix broken Sentencing and Probation "Judicial District" dropdowns (or remove them)
3 participants