-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new package for Spotlight Client #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it 馃檶
.gitignore
Outdated
@@ -38,3 +38,6 @@ yarn-error.log* | |||
|
|||
# Package files | |||
package-lock.json | |||
|
|||
# Typescript build artifacts | |||
*.tsbuildinfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: newline at the end
@@ -0,0 +1,13 @@ | |||
import React from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Let's make sure we've got license text at the top of each file in the app. We didn't do that in Covid-19 Dashboard but that was simply because I didn't bother to add that extra bit of friction during that time. But we should do it for every file we generate going forward that supports comments.
import App from "./App"; | ||
|
||
ReactDOM.render( | ||
<React.StrictMode> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! didn't know about StrictMode
before 馃憤
Description of the change
More configuration than code, but this adds a third package where we will start adding features for the new Spotlight application. Of note:
lint
script. They run in CI as well as in the pre-commit hook.Type of change
Related issues
Checklists
Development
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: