Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locality filter component #325

Merged
merged 3 commits into from
Jan 28, 2021
Merged

Locality filter component #325

merged 3 commits into from
Jan 28, 2021

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Jan 27, 2021

Description of the change

Creates another Dropdown variant, this time for filtering charts by location. To customize location names (which we need to do, since the raw location IDs are generally not suitable for display) we have to add that configuration to the content object per tenant. This does that and then creates a thin wrapper around Dropdown, similar to what was done for the demographic filter.

This isn't used anywhere in the UI yet but I did write some tests to put it through its paces. (Also added similar tests for the demographic filter component since it seemed like a good thing to have.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #299

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Jan 27, 2021

Pull Request Test Coverage Report for Build 513929533

  • 17 of 28 (60.71%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 65.174%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spotlight-client/src/contentModels/createMetricMapping.ts 11 22 50.0%
Totals Coverage Status
Change from base Build 513902997: -0.1%
Covered Lines: 1722
Relevant Lines: 2541

💛 - Coveralls

Copy link

@jovergaag jovergaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👯

@macfarlandian macfarlandian merged commit f4dde8d into master Jan 28, 2021
@macfarlandian macfarlandian deleted the ian/299-locality-filter branch January 28, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locality filter UI
3 participants