Data model for racial disparities narrative #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macfarlandian
changed the title
Pull Request Test Coverage Report for Build 623013360
💛 - Coveralls |
jovergaag
approved these changes
Mar 11, 2021
| export default class RacialDisparitiesNarrative { | ||
| // metadata | ||
| readonly title = "Racial Disparities"; | ||
|
|
||
| // TODO: customize text? |
There was a problem hiding this comment.
Did you want to resolve this TODO in this PR?
There was a problem hiding this comment.
yeah that comment was a straggler, it's resolved now
Comment on lines
+167
to
+170
| const fetchedData = await fetchAndTransformMetric({ | ||
| sourceFileName: "racial_disparities", | ||
| tenantId: this.tenantId, | ||
| transformFn: createRacialDisparitiesRecords, |
There was a problem hiding this comment.
This is a really nice pattern. Now, having seen the limitations of our DataStores, I appreciate more this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Reimplements the racial disparities data fetching and calculations in a new Mobx data model, and adds a few new ones.
There's a lot here, and it's a bit tedious, but nothing tricky and very little that is really new — just reorganized. Each text section and chart now has a corresponding method on the model that produces its data (with respect to any relevant filters), rather than there being one monolithic function that computes everything. Future states are not guaranteed to have all these sections and metrics, so this should help make this page more flexible in addition to hopefully being easier to read.
I verified the data snapshots by comparing them to the dynamic text and charts on v1 in demo mode. The new chart data is made up of the same data that goes into the text metrics, so I verified them against the text as well. (There were a few unrealistic values in the data fixture that made this confusing so I updated them -- namely, the total sentenced count did not add up to the sum of its parts, which was an artifact of earlier calc behavior that has since changed).
FWIW the commit history on this branch is pretty clean and can be reviewed sequentially, to demarcate the ported stuff from the new stuff if that helps make sense of this.
Type of change
Related issues
Checklists
Development
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: