-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Racial Disparities charts UI #358
Conversation
Pull Request Test Coverage Report for Build 647224664
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page is so impactful and well done 💯
{section.title} | ||
</NarrativeSectionTitle> | ||
{narrative.isLoading || | ||
narrative.isLoading === undefined ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why isLoading
is initially unset instead of set to true
, I think we may be setting it initially to true in lantern and I was wondering if you noticed unintended behavior with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah this came up way back when I was first setting up the data models. it basically serves as a signal that a fetch has not been initiated yet. all the models follow this convention ... there wasn't necessarily a problem with doing it the other way, this just seemed like a good idea at the time
Description of the change
Adds the chart UI (including filters, data download, and methodology) for all sections of the Racial Disparities narrative page.
Notable:
lodash
with the mothership because I realized the modular packages were deprecated and out of date (tried to uselodash.pick
and discovered it was way behind current functionality)Type of change
Related issues
Checklists
Development
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: