Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page not found .... page #368

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Page not found .... page #368

merged 3 commits into from
Mar 23, 2021

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Mar 18, 2021

Description of the change

Any URL that can't be resolved should now land you on a proper "not found" page.

Screen Shot 2021-03-17 at 4 13 07 PM

In cases where we can partially resolve the URL (i.e., the tenant is valid but something after it is not), the tenant-specific navigation should be present to give you more recovery paths. This involved changing how we handle invalid route parameters so they don't throw errors ... there is some wonky stuff associated with that but I tried to keep it all encapsulated in the withRouteSync function. It is also complicated somewhat by a bug in Reach Router that obliterates all the route parameters on default routes, so I had to use a wildcard path instead.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #361

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Mar 18, 2021

Pull Request Test Coverage Report for Build 663021110

  • 21 of 21 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 73.423%

Totals Coverage Status
Change from base Build 662889023: 0.2%
Covered Lines: 2691
Relevant Lines: 3559

💛 - Coveralls

@macfarlandian macfarlandian merged commit f921b58 into master Mar 23, 2021
@macfarlandian macfarlandian deleted the ian/361-not-found branch March 23, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not Found page
3 participants