Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Any URL that can't be resolved should now land you on a proper "not found" page.
In cases where we can partially resolve the URL (i.e., the tenant is valid but something after it is not), the tenant-specific navigation should be present to give you more recovery paths. This involved changing how we handle invalid route parameters so they don't throw errors ... there is some wonky stuff associated with that but I tried to keep it all encapsulated in the
withRouteSync
function. It is also complicated somewhat by a bug in Reach Router that obliterates all the route parameters on default routes, so I had to use a wildcard path instead.Type of change
Related issues
Checklists
Development
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: