Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared ESLint config #386

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Use shared ESLint config #386

merged 3 commits into from
Apr 8, 2021

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Apr 7, 2021

Description of the change

Replace the local eslint config with a shared package, with some minor adjustments to conform to new rules.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

part of https://github.com/Recidiviz/recidiviz-data/issues/6719

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@macfarlandian macfarlandian changed the title [WIP] Use shared ESLint config Use shared ESLint config Apr 8, 2021
@macfarlandian macfarlandian marked this pull request as ready for review April 8, 2021 19:20
@coveralls
Copy link

coveralls commented Apr 8, 2021

Pull Request Test Coverage Report for Build 730678200

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-16.4%) to 56.696%

Totals Coverage Status
Change from base Build 709306468: -16.4%
Covered Lines: 972
Relevant Lines: 1670

💛 - Coveralls

Copy link

@jovergaag jovergaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thaaaats nice.

}
}
}
"extends": ["@recidiviz"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@macfarlandian
Copy link
Collaborator Author

that big Coveralls drop, in case anyone was wondering, seems to be a glitch ... when you click through to the build it shows no change in coverage but it failed to include one of the packages in the final report. i'll keep an eye on it though

@macfarlandian macfarlandian merged commit 4970b32 into master Apr 8, 2021
@macfarlandian macfarlandian deleted the ian/shared-eslint-config branch April 8, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants