-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-tenant navigation with PA placeholder content #393
Conversation
Pull Request Test Coverage Report for Build 753224932
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to test it locally, but the testing looks thorough! I realized in reading this that I'm confused about the URL that users are using to access the app. Pls help :)
reactImmediately(() => { | ||
expect(tenantStore.currentTenant?.id).toBe("US_ND"); | ||
expect(tenantStore.currentTenantId).toBe("US_ND"); | ||
expect(tenantStore.locked).toBe(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a case where an org like CSG can view multiple tenants? I guess in this case they would not have a ".gov" email address... Just wondering if there is ever a use case that we would want to allow multiple tenant users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, as I have read this more thoroughly it looks like the tenant is coming from the current location. I guess I'm unclear how this is deployed in prod and the DNS magic that is allowing us to put this behind a .nd.gov
domain? Is this part of the agreement with ND?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it's a bit convoluted. We do not, as yet, actually have a spotlight.recidiviz.org
domain configured for prod. For ND they did indeed configure their own DNS to point dashboard.docr.nd.gov
at our prod Firebase environment, which has been fine because the whole site just defaults to ND as the only tenant. But now the expectation is that PA is going to do the same with something.pa.gov
, and eventually if we get a few more states on the platform we are going to want spotlight.recidiviz.org
to exist as well.
And then the additional staging subdomains just let us replicate those different experiences in the pre-release environment. (The default staging domain being spotlight-staging.recidiviz.org
, which is where you can access all the tenants at once)
Does that make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does, very helpful thanks!
expect(scrollSpy).toHaveBeenNthCalledWith(1, 0, 0); | ||
expect(scrollSpy).toHaveBeenNthCalledWith(2, 0, 0); | ||
}); | ||
expect(scrollSpy).toHaveBeenCalledWith(0, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool GibHub Actions linting error integration above!
Description of the change
Completes the initial preparations to support multiple tenants. In the final analysis this wound up including:
I tested as much of this functionality as I could in Jest but supplemented it with some pretty thorough manual testing, by editing my hosts file to point the domains of interest at my local dev server. There should be no change in behavior for the existing ND prod domain, and the new staging domains also worked as expected. (I also tested this in staging a bit but that environment isn't necessarily up to date with this branch now.)
Type of change
Related issues
Checklists
Development
These boxes should be checked by the submitter prior to merging:
Code review
These boxes should be checked by reviewers prior to merging: