Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure feedback URL per tenant #447

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Jun 4, 2021

Description of the change

Changes the URL for the feedback link (which appears in top navigation) from a constant to a unique URL configured per tenant. Also means we hide the link when there is no active tenant (has no practical effect in prod but you'll see it in dev or staging)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #397

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Jun 4, 2021

Pull Request Test Coverage Report for Build 907318076

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.069%

Totals Coverage Status
Change from base Build 900458251: 0.02%
Covered Lines: 1919
Relevant Lines: 2132

💛 - Coveralls

@macfarlandian macfarlandian merged commit 87f2781 into main Jun 4, 2021
@macfarlandian macfarlandian deleted the ian/397-feedback-urls branch June 4, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update feedback form to not be ND-specific
3 participants