Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make long lists of demographic unknowns collapsible #448

Merged
merged 4 commits into from
Jun 7, 2021

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Jun 5, 2021

Description of the change

Particularly with time series data, our treatment of people with unknown demographic properties can get pretty unwieldy if there are lots of them. We never had this problem in ND and so we never solved for it, but it does appear in the PA parole data. This just clamps the list at 3 entries with a button to expand or collapse it in place as needed. (With 3 or fewer entries the button will not be shown.)

Screen Shot 2021-06-04 at 5 22 07 PM

Screen Shot 2021-06-04 at 5 22 24 PM

The height change is animated with a technique I've used in several other places. Rather than duplicate it yet another time I have refactored it into a wrapper component. I haven't seen any regression in those sections. (This does make the PR look bigger than it really is due to indentation changes; you might want to hide them while reviewing.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #439

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Jun 5, 2021

Pull Request Test Coverage Report for Build 908048887

  • 34 of 35 (97.14%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.133%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spotlight-client/src/VizDemographicsByCategory/VizDemographicsByCategory.tsx 1 2 50.0%
Totals Coverage Status
Change from base Build 907448618: 0.1%
Covered Lines: 1936
Relevant Lines: 2151

💛 - Coveralls

@macfarlandian macfarlandian merged commit bbf45bd into main Jun 7, 2021
@macfarlandian macfarlandian deleted the ian/439-unknown-overflow branch June 7, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown numbers overflow bug
3 participants