Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parole terminations metric for PA #453

Merged
merged 3 commits into from
Jul 14, 2021
Merged

Conversation

macfarlandian
Copy link
Collaborator

Description of the change

This replaces the original parole success metric with the new "successful parole terminations" variation for Pennsylvania (necessary for data availability reasons, as seen in https://github.com/Recidiviz/recidiviz-data/pull/8155). Mostly this change is boilerplate and the new metric is a drop-in replacement, though it does require its own data transformation functions to handle the slightly different API response.

(Files are in staging, you can run the backend from this branch to test locally)

Type of change

  • New feature (non-breaking change that adds functionality)

Related issues

Closes #452

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Jul 13, 2021

Pull Request Test Coverage Report for Build 1027866502

  • 3 of 10 (30.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 84.946%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spotlight-client/src/contentModels/createMetricMapping.ts 3 4 75.0%
spotlight-client/src/metricsApi/SupervisionSuccessRateDemographicsRecord.ts 0 2 0.0%
spotlight-client/src/metricsApi/SupervisionSuccessRateMonthlyRecord.ts 0 4 0.0%
Totals Coverage Status
Change from base Build 969619346: -0.2%
Covered Lines: 1939
Relevant Lines: 2161

💛 - Coveralls

@macfarlandian macfarlandian merged commit 2e892cf into main Jul 14, 2021
@macfarlandian macfarlandian deleted the ian/452-termination-metric branch July 14, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace PA parole success with new successful termination success metric
3 participants