Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent dropdowns from flowing off the screen #464

Merged
merged 1 commit into from Jul 28, 2021
Merged

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Jul 28, 2021

Description of the change

Long dropdowns may compete with scroll-snapping behavior and make certain options difficult to access. This makes sure menus stay within the viewport and scroll their overflowing items if necessary.

dropdown scroll

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Closes #463

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Jul 28, 2021

Pull Request Test Coverage Report for Build 1076002835

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 84.934%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spotlight-client/src/UiLibrary/Dropdown/InPlaceMenu.tsx 6 7 85.71%
Totals Coverage Status
Change from base Build 1054096480: -0.01%
Covered Lines: 1943
Relevant Lines: 2165

💛 - Coveralls

@macfarlandian macfarlandian merged commit e4bc1b9 into main Jul 28, 2021
@macfarlandian macfarlandian deleted the ian/463-dropdown branch July 28, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SL_PA] Difficult to access dropdown item below the fold
3 participants