Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy revisions after PA review #466

Merged
merged 7 commits into from Jul 29, 2021
Merged

Copy revisions after PA review #466

merged 7 commits into from Jul 29, 2021

Conversation

macfarlandian
Copy link
Collaborator

Description of the change

Mostly this PR is a big raft of rewrites to the PA copy object. It also involved moving a few new items into that object that were previously hard-coded in components:

  • the title of the landing page
  • the contents of the "small data" disclaimer footnote that appears alongside most charts
  • the label for the revocation charts on the Racial Disparities page

Some other changes that are copy-adjacent and so also included here:

  • some tooltips were not properly formatting numbers with thousands separators; now they are
  • removed the Community Corrections section and metric from PA

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #460, closes #462, closes #465, closes #459

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Jul 28, 2021

Pull Request Test Coverage Report for Build 1076629624

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.948%

Totals Coverage Status
Change from base Build 1076355297: 0.01%
Covered Lines: 1946
Relevant Lines: 2168

💛 - Coveralls

Copy link
Contributor

@colincadams colincadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the quick turnaround!

Comment on lines -64 to -74
{
title: "Who is in a transitional facility?",
body: `<p>
People who are nearing the end of their prison term may be admitted to a
community correction center in advance of their release from incarceration.
These residential facilities, operated by the DOC or private contractors,
offer supportive programming to help prepare people for a successful
return to the community.
</p>`,
metricTypeId: "CommunityCorrectionsPopulationCurrent",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

she'll be back

@macfarlandian macfarlandian merged commit 2f9ac1d into main Jul 29, 2021
@macfarlandian macfarlandian deleted the ian/pa-final-copy branch July 29, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants