Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for legacy age categories #498

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

macfarlandian
Copy link
Collaborator

@macfarlandian macfarlandian commented Oct 29, 2021

Description of the change

Now that the new age categories are released and stable, we can remove our temporary support for the old ones in parallel with them (which was only in place for continuity while waiting for calc to start outputting the new data format).

Type of change

  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #479

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

coveralls commented Oct 29, 2021

Pull Request Test Coverage Report for Build 1400948663

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 85.141%

Files with Coverage Reduction New Missed Lines %
spotlight-client/src/metricsApi/types.ts 1 20.0%
Totals Coverage Status
Change from base Build 1400861097: -0.1%
Covered Lines: 1986
Relevant Lines: 2211

💛 - Coveralls

@macfarlandian macfarlandian merged commit 2ad3e08 into main Nov 1, 2021
@macfarlandian macfarlandian deleted the ian/479-cleanup branch November 1, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add older age buckets to Spotlight visualizations
3 participants