Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DumpType() needs a rewrite #14

Closed
patrickt opened this issue Nov 1, 2016 · 1 comment
Closed

DumpType() needs a rewrite #14

patrickt opened this issue Nov 1, 2016 · 1 comment

Comments

@patrickt
Copy link
Contributor

patrickt commented Nov 1, 2016

It doesn't conform to the output of DumpExprAsType.
patrickt pushed a commit that referenced this issue Nov 4, 2016
Rewrite DumpType() into specific DumpTypeAlias() [#14]
69cd79f 
DumpType was a legacy function from when I didn't understand that
TypeSpecs were used very rarely (only in top-level type alias
declarations). This rewrite uses DumpExprAsType and codifies the schema
for type aliases.
patrickt pushed a commit that referenced this issue Nov 4, 2016
Rewrite DumpType() into specific DumpTypeAlias() [#14]
6e79c29 
DumpType was a legacy function from when I didn't understand that
TypeSpecs were used very rarely (only in top-level type alias
declarations). This rewrite uses DumpExprAsType and codifies the schema
for type aliases.
bohde added a commit that referenced this issue Nov 4, 2016
@bohde
Merge pull request #23 from ReconfigureIO/bugfix/rewrite-type-aliases
6d082db 
Rewrite DumpType() into specific DumpTypeAlias() [#14]
@patrickt
Copy link
Contributor Author

patrickt commented Nov 4, 2016

Fixed!

@patrickt patrickt closed this as completed Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@patrickt