Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go fmt target to Makefile #39

Merged
merged 2 commits into from
Dec 15, 2016
Merged

Conversation

lanzafame
Copy link
Contributor

I have added the fmt target as a dependency of the test target as this suits a local development workflow well (i.e. add/change code -> make test => go fmt && go test) but I am not sure if this is ideal as that would mean that the Travis CI build will also run go fmt, but I will defer the decision to the maintainers.

The fmt target affects the fixtures directory and does change the formatting of the fixture files. I am assuming by the nature of the project (AST -> JSON) that the formatting shouldn't matter but thought it worth noting.

@codecov-io
Copy link

codecov-io commented Dec 15, 2016

Current coverage is 55.24% (diff: 100%)

Merging #39 into master will not change coverage

@@             master        #39   diff @@
==========================================
  Files             1          1          
  Lines           581        581          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            321        321          
  Misses          225        225          
  Partials         35         35          

Powered by Codecov. Last update a72e012...2f6d3ba

@patrickt
Copy link
Contributor

I use Emacs to hit gofmt automatically, but this looks good to me! Thank you!

@patrickt patrickt merged commit 1e38568 into ReconfigureIO:master Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants