Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpret the error returned from request.go #21

Merged
merged 8 commits into from
Mar 16, 2018

Conversation

CampGareth
Copy link
Contributor

Request.go generates a generic "Not Found" error when it gets a 404 from the API. We pass that back up the chain and report it to the user. That error could be a lot more specific if we interpret it at a level where we know what it was we were trying to access. This PR adds that interpreter at the command level so we can say 'deployment not found'.

@CampGareth
Copy link
Contributor Author

@CampGareth CampGareth changed the title [WIP] interpret the error returned from request.go interpret the error returned from request.go Mar 13, 2018
@CampGareth
Copy link
Contributor Author

Travis is marking this PR as failed because Travis is talking to github too much. It can be ignored for now, but I wonder if there's a way to rewrite that failing test so it doesn't talk to external services (since that's bad etiquette).

error message:

--- FAIL: TestLatestRelease (0.07s)
	update_test.go:13: GET https://api.github.com/repos/ReconfigureIO/reco/releases/latest: 403 API rate limit exceeded for 52.3.55.28. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 33m49s]
	update_test.go:16: Returned string is empty

@CampGareth CampGareth merged commit 7fe30e5 into master Mar 16, 2018
@CampGareth CampGareth deleted the fix/deployment-not-found-error branch March 16, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant